Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.14 upgrade #18

Merged
merged 12 commits into from
Dec 11, 2020
Merged

Terraform 0.14 upgrade #18

merged 12 commits into from
Dec 11, 2020

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Nov 6, 2020 •
edited by Nuru
Loading

what

  • Apply Cloud Posse standard updates for Terraform 0.14

why

  • Make module library compatible with Terraform 0.14

@maximmi maximmi requested review from osterman and aknysh November 6, 2020 17:17
@maximmi maximmi requested review from a team as code owners November 6, 2020 17:17
@maximmi
Copy link
Contributor Author

maximmi commented Nov 6, 2020

/test all

@maximmi maximmi requested a review from osterman November 12, 2020 09:55
@maximmi
Copy link
Contributor Author

maximmi commented Nov 26, 2020

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Nov 26, 2020

/test all

3 similar comments
@maximmi
Copy link
Contributor Author

maximmi commented Nov 26, 2020

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Nov 26, 2020

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Nov 30, 2020

/test all

@Nuru Nuru changed the title auto-update for context.tf and readme Terraform 0.14 upgrade Dec 10, 2020
osterman
osterman reviewed Dec 10, 2020
View reviewed changes
.github/workflows/auto-context.yml
run: |
if [[ -f context.tf ]]; then
echo "Discovered existing context.tf! Fetching most recent version to see if there is an update."
curl -o context.tf -fsSL https://raw.githubusercontent.com/cloudposse/terraform-null-label/master/exports/context.tf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call the context target from the build-harness?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is run 200 times nightly, I want to keep it light and not require build-harness. I will call build-harness if context.tf changes.

@Nuru Nuru requested a review from osterman December 10, 2020 06:03
@Nuru
Copy link
Contributor

Nuru commented Dec 11, 2020

/test all

@Nuru Nuru self-requested a review December 11, 2020 01:39
@Nuru Nuru added the patch A minor, backward compatible change label Dec 11, 2020
@Nuru Nuru merged commit d24a4f5 into master Dec 11, 2020
@Nuru Nuru deleted the auto-update-initial branch December 11, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@aknysh aknysh Awaiting requested review from aknysh

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @Nuru @osterman